Skip to content

Conversation

@ajanikow
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 15, 2025
@ajanikow ajanikow requested a review from Copilot November 15, 2025 18:15
Copilot finished reviewing on behalf of ajanikow November 15, 2025 18:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements request ID generation and standardizes HTTP headers to use the X-Arango-Platform prefix. The implementation adds a new request_id handler to the envoy auth chain that generates unique request IDs for tracking purposes, while maintaining backward compatibility by supporting both old and new header names.

  • New request ID generation handler that creates unique IDs using k8s uuid package
  • Header standardization with new X-Arango-Platform-Route and X-Arango-Platform-Request-Id headers
  • Backward compatible changes by maintaining deprecated arangodb-platform-route header alongside new version

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/util/constants/envoy.go Adds new header constants with deprecation marker for old header, removes unused EnvoyIntegrationSidecarClusterHTTP constant
pkg/deployment/resources/config_map_gateway.go Updates gateway config to set both old and new route headers for backward compatibility
integrations/envoy/auth/v3/impl/request_id/impl.go New handler implementation that generates unique request IDs and adds them to request/response headers
integrations/envoy/auth/v3/impl/impl.go Registers the new request_id handler as the first handler in the auth chain
CHANGELOG.md Documents the new feature in the changelog

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ajanikow ajanikow force-pushed the feature/platform/request_id branch from e066b2b to f5c3020 Compare November 17, 2025 21:43
@ajanikow ajanikow requested a review from Copilot November 18, 2025 10:32
Copilot finished reviewing on behalf of ajanikow November 18, 2025 10:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ajanikow ajanikow requested a review from Copilot November 18, 2025 12:03
Copilot finished reviewing on behalf of ajanikow November 18, 2025 12:06
@ajanikow ajanikow merged commit 61fc20e into master Nov 18, 2025
6 of 7 checks passed
@ajanikow ajanikow deleted the feature/platform/request_id branch November 18, 2025 12:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Header: &pbEnvoyCoreV3.HeaderValue{
Key: utilConstants.EnvoyRequestIDHeader,
Value: string(uuid.NewUUID()),
},
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HeaderValueOption should include an AppendAction field for consistency with other handlers and to explicitly define the header behavior. Consider adding:

var header = pbEnvoyCoreV3.HeaderValueOption{
	Header: &pbEnvoyCoreV3.HeaderValue{
		Key:   utilConstants.EnvoyRequestIDHeader,
		Value: string(uuid.NewUUID()),
	},
	AppendAction: pbEnvoyCoreV3.HeaderValueOption_OVERWRITE_IF_EXISTS_OR_ADD,
}

This ensures the request ID header behavior is predictable and consistent with the pattern used in other handlers like pass_mode.

Suggested change
},
},
AppendAction: pbEnvoyCoreV3.HeaderValueOption_OVERWRITE_IF_EXISTS_OR_ADD,

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants