Skip to content

Conversation

@ajanikow
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 15, 2025
@ajanikow ajanikow requested a review from Copilot November 15, 2025 19:46
Copilot finished reviewing on behalf of ajanikow November 15, 2025 19:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds redirect functionality to the ArangoRoute resource, allowing routes to respond with HTTP 301 (Moved Permanently) or 307 (Temporary Redirect) redirect responses instead of proxying to upstream services.

Key Changes:

  • Added ArangoRouteSpecDestinationRedirect API type to configure redirect target and status code (defaults to 307)
  • Implemented redirect handling in route handlers and Envoy gateway configuration
  • Extended checksum utility with filtered string array functions for improved hash calculations

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/util/checksum.sha256.go Added helper functions for filtering empty strings in hash calculations
pkg/apis/networking/v1beta1/route_spec_destination_redirect.go New API type defining redirect configuration with validation for allowed codes (301, 307)
pkg/apis/networking/v1beta1/route_status_target_redirect.go Status representation of redirect configuration
pkg/apis/networking/v1beta1/route_status_target_type.go Added redirect target type constant
pkg/apis/networking/v1beta1/route_spec_destination.go Integrated redirect as a mutually exclusive destination option
pkg/apis/networking/v1beta1/route_status_target.go Added redirect field to status and updated hash calculation
pkg/handlers/networking/route/handler_destination_redirect.go Handler implementation for processing redirect destinations
pkg/handlers/networking/route/handler_destination.go Added redirect handler invocation to destination processing
pkg/deployment/resources/gateway/gateway_config_destination_type.go Added redirect destination type to gateway config enum
pkg/deployment/resources/gateway/gateway_config_destination_redirect.go Gateway-level redirect configuration with validation
pkg/deployment/resources/gateway/gateway_config_destination.go Envoy route action generation for redirect responses
pkg/handlers/networking/route/handler_destination_redirect_test.go Comprehensive test coverage for redirect scenarios including valid/invalid configurations
pkg/apis/networking/v1beta1/zz_generated.deepcopy.go Generated deep copy methods for redirect types
pkg/crd/crds/networking-route.schema.generated.yaml CRD schema updates for redirect configuration
pkg/apis/shared/validate.go Added ValidateMultiPath utility for multiple validators on same field
docs/api/ArangoRoute.V1Beta1.md Documentation for redirect configuration fields
CHANGELOG.md Added feature entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ajanikow ajanikow force-pushed the feature/platform/route_redirect_impl branch 2 times, most recently from 36ba708 to 8110c74 Compare November 17, 2025 17:57
@ajanikow ajanikow force-pushed the feature/platform/route_redirect_impl branch from 8d0d9fd to d46db5c Compare November 17, 2025 20:29
@ajanikow ajanikow merged commit 491f7d8 into master Nov 17, 2025
3 checks passed
@ajanikow ajanikow deleted the feature/platform/route_redirect_impl branch November 17, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants