Skip to content

Conversation

@Simran-B
Copy link
Contributor

Only typos so far, might have to fix a few Gitbook related issues as well.

Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Simran-B
Copy link
Contributor Author

We won't add Cygwin-specific workarounds for the template render issues at this time as discussed with @sleto-it. I'll try to get documentation building working with the Windows Subsystem for Linux (WSL). We should edit the Cookbook and Documentation maintainer readme accordingly if we don't support Cygwin anymore. One final test could be to use LF line endings for everything in git and re-clone to make sure it's not a line ending issue again.

@Simran-B Simran-B merged commit 598ff5e into master Jun 28, 2018
@ghost ghost removed the 2 - Working label Jun 28, 2018
@ewoutp ewoutp deleted the documentation/fixes branch August 9, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants