Skip to content

Conversation

@maierlars
Copy link
Contributor

Added secret force-status-reload status field. ✌️

@maierlars maierlars self-assigned this Feb 11, 2019
@maierlars maierlars requested a review from neunhoef February 11, 2019 13:19
@ghost ghost added the 2 - Working label Feb 11, 2019
Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

// detect changes in secret values.
SecretHashes *SecretHashes `json:"secret-hashes,omitempty"`

// ForceStatusReload if set to true forces a reload of the status from the CR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomResource

@maierlars
Copy link
Contributor Author

This would allow easy patching of the status, when the operator is not able to recover by itself - without removing and redeploying the operator which might not be that easy.

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef neunhoef merged commit 5b720d2 into master Feb 18, 2019
@neunhoef neunhoef deleted the bug-fix/force-status-reload branch February 18, 2019 10:15
@ghost ghost removed the 2 - Working label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants