Skip to content

Implemented isDefault behavior of storage class #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2018
Merged

Implemented isDefault behavior of storage class #35

merged 2 commits into from
Mar 8, 2018

Conversation

@ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 8, 2018 •
edited
Loading

This PR implements the changing of default storage behavior needed when you create an ArangoLocalStorage with spec.storageClass.isDefault: true

@ewoutp ewoutp requested a review from ObiWahn March 8, 2018 09:21
@ewoutp ewoutp mentioned this pull request Mar 8, 2018
Closed
18 tasks
ObiWahn
ObiWahn approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@ObiWahn ObiWahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 262e57d into master Mar 8, 2018
@ewoutp ewoutp deleted the storage-class-default branch March 8, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ObiWahn ObiWahn ObiWahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ewoutp @ObiWahn