Volume resizing #357
Merged
Volume resizing #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maierlars
changed the title
ewoutp
reviewed
Mar 18, 2019
Contributor
ewoutp
left a comment
ewoutp
left a comment
There was a problem hiding this comment.
Code looks clean, but does it really work?
According to https://kubernetes.io/blog/2018/07/12/resizing-persistent-volumes-using-kubernetes/ you need to restart the pod for the filesystem to be resized.
ewoutp
reviewed
Mar 18, 2019
Contributor
ewoutp
left a comment
ewoutp
left a comment
There was a problem hiding this comment.
Missing an event on shrinking & test about shrinking.
After that LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for volume resize. Added code to do so.