Skip to content

Conversation

@maierlars
Copy link
Contributor

Removed vendored directory. Use arangosync-client repo instead.

@maierlars maierlars requested review from ewoutp, joerg84 and neunhoef June 25, 2019 10:06
@maierlars maierlars self-assigned this Jun 25, 2019
@ewoutp
Copy link
Contributor

ewoutp commented Jun 26, 2019

External loading problem:

$ GO111MODULE=on go get github.com/arangodb/kube-arangodb@bug-fix/arangosync-client
go: finding github.com/arangodb/kube-arangodb bug-fix/arangosync-client
go: finding github.com/arangodb/arangosync-client v0.6.3
go: downloading github.com/arangodb/kube-arangodb v0.0.0-20190625100602-f6e3db5fd037
go: extracting github.com/arangodb/kube-arangodb v0.0.0-20190625100602-f6e3db5fd037
go: downloading golang.org/x/sys v0.0.0-20190506115046-ca7f33d4116e
go: downloading golang.org/x/net v0.0.0-20190503192946-f4e77d36d62c
go: downloading k8s.io/kube-openapi v0.0.0-20190502190224-411b2483e503
go: downloading github.com/arangodb/arangosync-client v0.6.3
go: downloading golang.org/x/crypto v0.0.0-20190426145343-a29dc8fdc734
go: downloading github.com/coreos/prometheus-operator v0.30.0
go: extracting github.com/arangodb/arangosync-client v0.6.3
go: downloading github.com/ugorji/go/codec v0.0.0-20181209151446-772ced7fd4c2
go: extracting github.com/ugorji/go/codec v0.0.0-20181209151446-772ced7fd4c2
go: extracting golang.org/x/crypto v0.0.0-20190426145343-a29dc8fdc734
go: extracting k8s.io/kube-openapi v0.0.0-20190502190224-411b2483e503
go: extracting golang.org/x/net v0.0.0-20190503192946-f4e77d36d62c
go: extracting golang.org/x/sys v0.0.0-20190506115046-ca7f33d4116e
go: extracting github.com/coreos/prometheus-operator v0.30.0
go: downloading github.com/go-openapi/spec v0.18.0
go: extracting github.com/go-openapi/spec v0.18.0
go: downloading github.com/go-openapi/swag v0.18.0
go: extracting github.com/go-openapi/swag v0.18.0
build github.com/arangodb/kube-arangodb: cannot load github.com/ugorji/go/codec: ambiguous import: found github.com/ugorji/go/codec in multiple modules:
	github.com/ugorji/go v1.1.4 (/Users/ewout/go/pkg/mod/github.com/ugorji/go@v1.1.4/codec)
	github.com/ugorji/go/codec v0.0.0-20181209151446-772ced7fd4c2 (/Users/ewout/go/pkg/mod/github.com/ugorji/go/codec@v0.0.0-20181209151446-772ced7fd4c2)

Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good, but there is a dependency problem

@ewoutp
Copy link
Contributor

ewoutp commented Jun 27, 2019

I can now build against this branch

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef neunhoef merged commit a0e2c3e into master Jul 8, 2019
@neunhoef neunhoef deleted the bug-fix/arangosync-client branch July 8, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants