Skip to content

Conversation

@kvahed
Copy link
Contributor

@kvahed kvahed commented Jul 17, 2019

added side car changes to pod rotation triggering

@kvahed kvahed requested review from maierlars and neunhoef July 17, 2019 13:47
@kvahed kvahed self-assigned this Jul 17, 2019
@kvahed kvahed added the 9 WIP label Jul 17, 2019
@kvahed kvahed removed the 9 WIP label Jul 17, 2019
Copy link
Contributor

@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix style. See go fmt.
Please remove asserts.go. This file is autogenerated.

Done

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef neunhoef merged commit 08ecc44 into master Jul 31, 2019
@neunhoef neunhoef deleted the feature/restart-pods-on-sidecar-changes branch July 31, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants