Sidecar Issues 2 #434
Merged
Sidecar Issues 2 #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 5, 2019 15:28
joerg84
reviewed
Aug 5, 2019
| } | ||
|
|
||
| return false | ||
| return !reflect.DeepEqual(wanted, given) |
Contributor
There was a problem hiding this comment.
How good is the test coverage here?
joerg84
approved these changes
Aug 5, 2019
ajanikow
approved these changes
Aug 5, 2019
Contributor
Author
|
This needs some clever testing to prevent regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved status update to pod creation. Used deepEquals for pointers.
fixes #431
fixes #432