Skip to content

Add Default Role access for Finalizers #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2019
Merged

Add Default Role access for Finalizers #453

merged 1 commit into from
Sep 25, 2019

Conversation

@ajanikow
Copy link
Collaborator

@ajanikow ajanikow commented Sep 25, 2019

No description provided.

maierlars
maierlars approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neunhoef
neunhoef approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef neunhoef merged commit 3b93ae8 into master Sep 25, 2019
@neunhoef neunhoef deleted the bug/add_default_role_access branch September 25, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neunhoef neunhoef neunhoef approved these changes

+1 more reviewer

@maierlars maierlars maierlars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajanikow @neunhoef @maierlars