Skip to content

[Bugfix] Fix rotation phase #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2020
Merged

[Bugfix] Fix rotation phase #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/deployment/resources/pod_inspector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ func (r *Resources) InspectPods(ctx context.Context, cachedStatus inspector.Insp
case api.MemberPhaseNone:
// Do nothing
log.Debug().Str("pod-name", podName).Msg("PodPhase is None, waiting for the pod to be recreated")
case api.MemberPhaseShuttingDown, api.MemberPhaseRotating, api.MemberPhaseUpgrading, api.MemberPhaseFailed:
case api.MemberPhaseShuttingDown, api.MemberPhaseUpgrading, api.MemberPhaseFailed:
// Shutdown was intended, so not need to do anything here.
// Just mark terminated
wasTerminated := m.Conditions.IsTrue(api.ConditionTypeTerminated)
Expand All @@ -217,6 +217,7 @@ func (r *Resources) InspectPods(ctx context.Context, cachedStatus inspector.Insp
return maskAny(err)
}
}
case api.MemberPhaseRotating:
fallthrough
default:
log.Debug().Str("pod-name", podName).Msg("Pod is gone")
Expand Down