[Feature] Agency Cache #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwierzbo
approved these changes
Dec 6, 2021
informalict
approved these changes
Dec 6, 2021
Contributor
informalict
left a comment
informalict
left a comment
There was a problem hiding this comment.
LGTM with two comments
| } | ||
|
|
||
| if _, ok := state.Plan.Collections["_system"]; !ok { | ||
| return State{}, errors.Newf("Unable to find system database (invalid data)") |
Contributor
There was a problem hiding this comment.
Unable to find system database (invalid data) -> Unable to find system database in the plan (invalid data)
Collaborator
Author
There was a problem hiding this comment.
This error should never happen, unless agency is not totally broken
| // | ||
| // DISCLAIMER | ||
| // | ||
| // Copyright 2016-2021 ArangoDB GmbH, Cologne, Germany |
Contributor
There was a problem hiding this comment.
why 2016. it is a new file and should start with 2021
Collaborator
Author
There was a problem hiding this comment.
We use everywhere licenses like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.