[Feature] Allow to disable ClusterScalingIntegration and add proper S… #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cheduled label to pods
jwierzbo
approved these changes
Dec 10, 2021
informalict
reviewed
Dec 10, 2021
| } | ||
|
|
||
| if k8sutil.IsPodScheduled(pod) { | ||
| if _, ok := pod.Labels[k8sutil.LabelKeyArangoScheduled]; k8sutil.IsPodScheduled(pod) && !ok { |
Contributor
There was a problem hiding this comment.
why we check k8sutil.IsPodScheduled(pod) twice? in line 189 it was checked
Collaborator
Author
There was a problem hiding this comment.
Will fix it - small issue which just use cycles
| return t.ID == m.ID | ||
| } | ||
|
|
||
| func (t *TopologyStatus) IsTopologyEvenlyDistributed(group ServerGroup) bool { |
Contributor
There was a problem hiding this comment.
I would like to have a description here. What function should return when t.Zones is empty. Currently,
the function IsTopologyEvenlyDistributed returns false (not distributed evenly) when t.Zones are empty. Is it intentional? The description of the function should explain it because I don't know the intensions
Collaborator
Author
There was a problem hiding this comment.
And t.Zones cant be with size 0 - it is checked in code. If it is, then false is expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cheduled label to pods