[Feature] Core containers #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
informalict
commented
Dec 28, 2021
jwierzbo
approved these changes
Dec 28, 2021
informalict
commented
Dec 29, 2021
ajanikow
changed the title
ajanikow
approved these changes
Dec 29, 2021
Collaborator
ajanikow
left a comment
ajanikow
left a comment
There was a problem hiding this comment.
After fixing comment please merge
informalict
commented
Dec 29, 2021
| return nil | ||
| } | ||
|
|
||
| if !(k8sutil.IsPodSucceeded(pod) || k8sutil.IsPodFailed(pod) || k8sutil.IsPodTerminating(pod)) { |
Contributor
Author
There was a problem hiding this comment.
@ajanikow I moved this code below, so in consequence it will not be launched when it is not possible to fetch MemberStatusByPodName in the function below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.