Feature/advanced insync discovery #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajanikow
commented
Mar 9, 2022
nikita-vanyasin
changed the title
informalict
reviewed
Mar 10, 2022
… wait_for_member_in_sync is also updated
nikita-vanyasin
force-pushed
the
feature/advanced_insync_discovery
branch
from
cec7aa9 to
5c0e0f2
Compare
nikita-vanyasin
changed the title
nikita-vanyasin
force-pushed
the
feature/advanced_insync_discovery
branch
from
5c0e0f2 to
e245fd3
Compare
…t, add new test case
nikita-vanyasin
force-pushed
the
feature/advanced_insync_discovery
branch
from
7ab8d48 to
5664552
Compare
nikita-vanyasin
force-pushed
the
feature/advanced_insync_discovery
branch
from
5664552 to
6d41f7e
Compare
ajanikow
commented
Mar 17, 2022
| func (a *actionWaitForMemberInSync) checkCluster() (bool, error) { | ||
| if !a.actionCtx.GetShardSyncStatus() { | ||
| agencyState, ok := a.actionCtx.GetAgencyCache() | ||
| if !ok || agencyState.IsDBServerInSync(a.MemberID()) { |
Collaborator
Author
There was a problem hiding this comment.
What if you are not DBServer?
ajanikow
force-pushed
the
feature/advanced_insync_discovery
branch
from
fbe5aa3 to
422fc8e
Compare
ajanikow
force-pushed
the
feature/advanced_insync_discovery
branch
from
422fc8e to
b159fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.