Added session based client. Cleaned up a few tests. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons on, added close method to sessionbased client, and added session_based boolean method to base class so code can be written to call close if necessary for cleanup
Contributor
|
Hello avinash240, Thanks for your interest and help on py-arango! I've created a new branch called "development". Could you redirect your pull request to it? Thanks. |
Contributor
Author
|
Sure. No worries. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session based client is faster than the default one, especially at high rates. It's no longer paying the connection and breakdown penalty per socket and instead is connection pooling, which is great. There are two tests, the geo tests. They don't return back the unique flag that you send in, I suspect that that index type does not support unique. However, I'm new to arangodb, so I don't know perhaps it's a bug in the server I'm running 2.5.5. I also added the sparse and selectivity keys where needed. I'm not sure if this breaks backwards compat with older servers, I'm sorry if it does, I just didn't want to hand back a broken test suite especially since you went through the trouble to build one.