Skip to content

Conversation

@grospelliergilles
Copy link
Member

The goal is to hide implementation of the property machinery.
Update ParallelLoopOptions and ApplicationInfo to use the new mechanism.

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Nov 27, 2024
@grospelliergilles grospelliergilles self-assigned this Nov 27, 2024
…ionnant la propriété de l'instance modifiée.

Utilise cela pour 'ParallelLoopOPtions' et 'ApplicationInfo'.
@grospelliergilles grospelliergilles force-pushed the dev/gg-decouply-property-instance-from-setter branch from 0fb4ee1 to 5538107 Compare November 27, 2024 18:46
@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (efa1529) to head (5538107).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/utils/JSONPropertyReader.h 0.00% 2 Missing ⚠️
arcane/src/arcane/launcher/ArcaneLauncher.cc 80.00% 1 Missing ⚠️
.../arcane/utils/internal/ApplicationInfoProperties.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
+ Coverage   70.24%   70.26%   +0.01%     
==========================================
  Files        2259     2260       +1     
  Lines      162380   162382       +2     
  Branches    18705    18705              
==========================================
+ Hits       114064   114094      +30     
+ Misses      41543    41517      -26     
+ Partials     6773     6771       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 4cf87ed into main Nov 27, 2024
31 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-decouply-property-instance-from-setter branch November 30, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arcane Arcane Component refactoring Code refactoring and cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants