Add alignment requirement for synchronize buffer #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grospelliergilles
added
bug
…fers de synchronisation. Avant cette PR, en cas de synchronisation multiple, les données étaient rangées consécutivement en mémoire. Cela peut conduire à utiliser une adresse mémoire ne respectant pas certaines constraintes. Par exemple, si on synchronise une variable de type octet et de type Int32 en même temps et qu'on a 17 éléments, le buffer pour le type 'Int32' aura comme offset 17 ce qui peut poser problème sur certaines architectures ( par exemple les GPUs). Avec cette PR, on garantit un alignement d'au moins celui nécessaire pour 'std::max_align_t'.
grospelliergilles
force-pushed
the
dev/gg-add-alignment-requirement-for-sync-buffer
branch
from
4bc9ad2 to
b2a7192
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
+ Coverage 70.79% 70.82% +0.02%
==========================================
Files 2331 2331
Lines 170404 170440 +36
Branches 19802 19808 +6
==========================================
+ Hits 120640 120712 +72
+ Misses 42488 42451 -37
- Partials 7276 7277 +1 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-add-alignment-requirement-for-sync-buffer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, in the case of multiple synchronization, data was stored consecutively in memory. This could lead to the use of a memory address that did not comply with certain constraints.
For example, if a variable of type
Byteand an variable of typeInt32were synchronized at the same time and there are 17 elements, the buffer for theInt32type will have an offset of 17, which can cause problems on certain architectures (for example GPUs).With this PR, we guarantee an alignment of at least that required for
std::max_align_t.