Add support for ROCM 7.0 #2212
Merged
Add support for ROCM 7.0 #2212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate de 'grid_reduce' et 'block_reduce'.
Avec ROCM 7, la taille d'un warp n'est plus connue à la compilation. C'est 32 ou 64 en fonction de l'architecture et une même carte peut supporter les 2 valeurs (les cartes RDNA). On utilise une classe template avec la taille d'un warp comme paramètre pour gérer les deux cas. Cela permet aussi de ne pas changer le code pour les autres plateformes.
…ime et du driver pour HIP.
grospelliergilles
added
arcane
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2212 +/- ##
==========================================
- Coverage 71.51% 71.51% -0.01%
==========================================
Files 2344 2344
Lines 171886 171891 +5
Branches 19995 19995
==========================================
+ Hits 122930 122933 +3
- Misses 41505 41508 +3
+ Partials 7451 7450 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only modification is for reduction implementation.
The value
warpSizeis no longer aconstexprwith ROCM 7. It is now a dynamic value.We can no longer use it as a dimension for shared array.
Instead we use a template parameter with two possible values (
32or64) for warp size. It may have an performance impact so we have to benchmark that.This is only on ROCM 7 so it will be easy to do comparison between ROCM 6 and ROCM 7.