Remove accelerator reduction implementation using atomics #2214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grospelliergilles
added
arcane
…t les atomiques. Cette implémentation n'est plus accessible depuis la version 3.15. Seule la version utilisant la grille est accessible.
grospelliergilles
force-pushed
the
dev/gg-remove-atomic-reduce-implementation
branch
from
b775820 to
359d496
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
=======================================
Coverage 71.51% 71.51%
=======================================
Files 2345 2345
Lines 171894 171891 -3
Branches 19995 19995
=======================================
+ Hits 122932 122935 +3
+ Misses 41512 41507 -5
+ Partials 7450 7449 -1 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-remove-atomic-reduce-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is no longer available in version 3.15.
The grid implementation is faster and is reproducible between runs