Fix ItemsOwnerBuilder::computeNodesOwner() for non manifold mesh
#2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es maillages non-manifold. Avant cette PR on considérait qu'il fallait uniquement traiter les noeuds appartenant dont les faces ne sont connectées qu'à une seule maille car ce sont les seuls à être en bordure du maillage. Mais ce n'est pas le cas avec un maillage non-manifold ou comportement des mailles de plusieurs dimensions. Pour ce cas on envoie tous les noeuds pour garantir que l'algorithme fonctionne dans tout les cas.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2236 +/- ##
=======================================
Coverage 71.51% 71.51%
=======================================
Files 2347 2347
Lines 172025 172032 +7
Branches 20022 20025 +3
=======================================
+ Hits 123023 123033 +10
+ Misses 41544 41541 -3
Partials 7458 7458 ☔ View full report in Codecov by Sentry. |
…s pour un maillage 'non-manifold'.
grospelliergilles
force-pushed
the
dev/gg-fix-items-owner-builder-for-non-manifold-mesh
branch
from
dd83742 to
4330b68
Compare
grospelliergilles
deleted the
dev/gg-fix-items-owner-builder-for-non-manifold-mesh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, it was considered that only nodes whose faces are connected to a single cell should be processed, as these are the only ones at the edge of the mesh. However, this is not the case with non-manifold mesh or multi-dimensional mesh. In this case, all nodes are sent to ensure that the algorithm works in all cases.