fix: filter Sentry noise from tests and user cancellations#169
Merged
rhuanbarreto merged 1 commit intomainfrom Mar 24, 2026
Merged
fix: filter Sentry noise from tests and user cancellations#169rhuanbarreto merged 1 commit intomainfrom
rhuanbarreto merged 1 commit intomainfrom
Conversation
- Disable Sentry in test environments (enabled: NODE_ENV !== "test") to prevent test exceptions from polluting production error tracking - Add beforeSend filter to drop ExitPromptError events (Ctrl+C) - Handle ExitPromptError gracefully in CLI catch block with exit 130 - Update ARCH-002 to include exit code 130 (SIGINT convention) - Update ARCH-005 with Don't for Sentry in tests - Update exit-code-convention rule to allow code 130 Fixes CLI-1, Fixes CLI-2
Deploying archgate-cli with
|
| Latest commit: |
f0f9f83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04ade83d.archgate-cli.pages.dev |
| Branch Preview URL: | https://fix-sentry-noise-filtering.archgate-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enabled: Bun.env.NODE_ENV !== "test"toSentry.init()so test-invokedcaptureException()calls never reach production Sentry (fixes CLI-1, 195 noise events)beforeSendfilter that drops Inquirer Ctrl+C cancellations before they reach Sentry (fixes CLI-2)main().catch()now detectsExitPromptErrorand exits with code 130 (POSIX SIGINT convention) instead of logging an error and exiting with code 2exit-code-conventionrule updatedTest plan
bun run validatepasses (599 tests, 22/22 ADR checks, build compiles)archgate initexits silently (code 130, no Sentry event)