Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Creation of a zip file with no files or folders in it never triggers on 'close' #57

Closed
saadtazi opened this Issue · 3 comments

2 participants

@saadtazi

Hi,
I am not sure if it is a bug or expected behaviour in 0.5, but the following code behaves differently in 0.4 and 0.5.0:

var fs = require('fs'),
    archiver = require('archiver');

function go() {

  var zipStream = fs.createWriteStream('./profile.zip'),
    archive = archiver('zip', { forceUTC: true });

  zipStream.on('close', function() {
  console.log('ok, created');
  });
  archive.pipe(zipStream);

  archive.finalize();
}

go();

In 0.4, on 'close' is called, but not with 0.5. Note that the zip is created.

(I know that creating an empty zip file seems weird... It's just a test scenario actually)

@ctalkington
Owner

noted. will review first chance.

@ctalkington
Owner

v0.5.1 has been published. let me know if that doesn't fix it.

@saadtazi

It is fixed! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.