Skip to content

Conversation

@soyuka
Copy link
Contributor

@soyuka soyuka commented Jun 17, 2017

title

@soyuka soyuka mentioned this pull request Jun 17, 2017
@ctalkington
Copy link
Member

so im thinking we need a little more here. since this all is based on using the fs.stats object, it doesnt account for some of the manual methods of adding entries. for example, if i add a buffer or stream.

@soyuka
Copy link
Contributor Author

soyuka commented Jun 17, 2017

Hmm, when something is added through those manual methods, don't they go through _moduleAppend? Which method are you refering to?

@ctalkington
Copy link
Member

the ones im thinking would be the ones that go through a push to _queue. directly.

@ctalkington
Copy link
Member

i guess this all works for someone using purely fs based methods. so i wonder if name it something like fsProgress as i feel progress is misleading since we have a harder time being consistent between methods specially if used in a mixed fashion.

@ctalkington
Copy link
Member

that or what if we just say, progress is purely number of entries processed to number of entries given. then have a subpropery like progress.fs which has total bytes read from fs and total written

@soyuka
Copy link
Contributor Author

soyuka commented Jun 17, 2017

We're not aware of the number of entries given, or are we?

Surely agree with fs mention. I'll take a look at _queue.

@soyuka
Copy link
Contributor Author

soyuka commented Jun 17, 2017

#250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants