Promise support #248
Merged
Promise support #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
commented
Jun 17, 2017
| this._finalize(); | ||
| } | ||
|
|
||
| return this; |
Contributor
Author
There was a problem hiding this comment.
return signature changes hence backward compatibility break
soyuka
commented
Jun 17, 2017
| return new Promise(function(resolve, reject) { | ||
| var errored; | ||
|
|
||
| self._module.on('end', function() { |
Contributor
Author
There was a problem hiding this comment.
Lmk if close is better here.
Member
There was a problem hiding this comment.
hum, that difference usually matters more for fs.
There was a problem hiding this comment.
Why not finish ?
soyuka
commented
Jun 17, 2017
| return this; | ||
| var self = this: | ||
|
|
||
| return new Promise(function(resolve, reject) { |
Contributor
Author
There was a problem hiding this comment.
instead of self we could use an arrow function (note sure node 4 supports it without the --harmony flag)
ctalkington
approved these changes
Jun 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.