This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Added support for libraries that don't have a properties file #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directory. This is enough to determine whether the library exists and adds support for libraries that don't specify the properties file. The properties file is found later in the `add_arduino_library` function. Added an example for a properties-less library named 'Skywriter'.
…ary` function. It's no longer used as the function automatically finds this file itself.
…ths. It also can search the 'libraries' and 'dependencies' sub-dirs.
…aders. This is relevant for libraries conforming to the 1.0 standard, where there's no 'src' sub-dir. The specs say that besides the root dir, 'utility' sub-dir should be part of the search as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature required the core find-lib process to change as such:
Due to latest refactoring changes, the
add_arduino_libraryalso handles finding the properties file itself, so all thefind_arduino_libraryfunction does now is gather the required sources and headers.An example of a library without a properties file has also been added, testing against the Skywriter library.
This PR also fixed a potential bug where the utility sub-dir hasn't been searched for libraries that conform to the 1.0 standard, which is against what specified in the Arduino specs.
At last, it's now also possible to find libraries under cmake's source directory and project directory.
The libraries and dependencies sub-directories are also searched under each general search path.
The source directory is the directory from which the CMakeLists.txt file is executed.
Fixes #28