Skip to content

Conversation

@ashutoshshrm529
Copy link

@ashutoshshrm529 ashutoshshrm529 commented Mar 23, 2020

A solution for #5

Here I have tried to make text color completely independent of stroke color.
I have also added another clone bitmap function ( text_bitmap ) which uses the text color instead of stroke. I preserved the original bitmap function since I was not sure about its uses elsewhere. Now the text color can be set using both the setTextColor function or the BeginText functions with color inputs.

Please review and suggest changes as you may see fit.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@leonardocavagnis
Copy link
Contributor

leonardocavagnis commented Sep 2, 2024

Since this library is based on the Processing API, and according to the Processing text() documentation, the font color should indeed be changed using the fill() function.

This PR is being closed due to inconsistency with the Processing API.

@per1234 per1234 added type: enhancement Proposed improvement conclusion: declined Will not be worked on topic: code Related to content of the project itself labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants