Skip to content

Correct macro name in comments #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Correct macro name in comments #37

merged 1 commit into from
Dec 17, 2020

Conversation

@per1234
Copy link
Contributor

@per1234 per1234 commented Nov 1, 2020

The HOLDING_REGISTERS macro was incorrectly referred to as "HOLD_REGISTERS".

Reference:

ArduinoModbus/src/ModbusClient.h

Line 31 in 5bf098b

#define HOLDING_REGISTERS 2

Incidentally reported at (but doesn't fix) arduino/Arduino#10910

@per1234
Correct macro name in comments
d5ed65e 
The `HOLDING_REGISTERS` macro was incorrectly referred to as "HOLD_REGISTERS".
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Nov 1, 2020
aentinger
aentinger approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @per1234 🚀

@aentinger aentinger merged commit 6d323c5 into arduino-libraries:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aentinger aentinger aentinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@per1234 @aentinger