Skip to content

Conversation

@aentinger
Copy link
Contributor

There was an additional bug concerning erroneous unit conversion.

… being used.

There was an additional bug concerning erroneous unit conversion.
@aentinger aentinger requested a review from gbr1 July 9, 2024 11:42
@aentinger aentinger self-assigned this Jul 9, 2024
@gbr1
Copy link
Collaborator

gbr1 commented Jul 9, 2024

Hi @aentinger thank you for your fix! Please make this merge into devel, so it will added to next library update :D

Copy link
Collaborator

@gbr1 gbr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me :D

@aentinger
Copy link
Contributor Author

Why into devel (It's 5 commits behind main at this very moment)? Latest working code per definition is usually in main. I'll merge into main, feel free to merge main into devel (or rebase devel onto main).

@aentinger aentinger merged commit 7e0b929 into main Jul 10, 2024
@aentinger aentinger deleted the tmp-branch branch July 10, 2024 03:30
@gbr1
Copy link
Collaborator

gbr1 commented Jul 10, 2024

@aentinger now release is different to main :D
We are preparing a new release with other implementations

@per1234 per1234 added the bug Something isn't working label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants