Skip to content

Conversation

@per1234
Copy link
Contributor

@per1234 per1234 commented Feb 14, 2022

Initial development of the project was done in a private repository. In that environment, the most efficient configuration of the workflow is done by running the arduino/report-size-deltas action from a job in the same workflow, and so the workflow was configured that way.

However, that configuration is not suitable for use in a public repository. The reason is that the deltas report comment requires a GitHub access token with write permissions and the token does not have such permissions when the "Compile Examples" workflow is triggered by events in a pull request from a fork. For this reason, it is now necessary to run the arduino/report-size-deltas action from a dedicated scheduled workflow, which will always have write permissions.

Initial development of the project was done in a private repository. In that environment, the most efficient
configuration of the workflow is done by running the `arduino/report-size-deltas` action from a job in the same
workflow.

However, that configuration is not suitable for use in a public repository. The reason is that the deltas report comment
requires a GitHub access token with write permissions and the token does not have such permissions when the
"Compile Examples" workflow is triggered by events in a pull request from a fork. For this reason, it is necessary to
run the `arduino/report-size-deltas` action from a dedicated scheduled workflow, which will always have write
permissions.
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Feb 14, 2022
@per1234 per1234 requested a review from aentinger February 14, 2022 12:32
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @per1234 🚀

@aentinger aentinger merged commit 471418a into arduino-libraries:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: infrastructure Related to project infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants