Skip to content

Conversation

@sandeepmistry
Copy link
Contributor

From the discussion in #1 (comment).

cc/ @tigoe @SimonePDA @per1234 @cmaglie

@SimonePDA
Copy link

I am not sure if "brightness" is the right name of this measured value. It is the reading of the luminous flux that hits the sensor. If this flux is unfocused and from the environment it is the "ambient light" reading.

@sandeepmistry
Copy link
Contributor Author

@SimonePDA thanks for the feedback, do you have a preferred API name then?

@SimonePDA
Copy link

Let's hear what the others have to say.

@tigoe
Copy link

tigoe commented Apr 24, 2019 via email

@SimonePDA
Copy link

As I added on the main lib page, the UVa and UVb vaue is the count of μW/cm2; this is stated on the datasheet.

The UVIndex is an index, from 0 to 11+ with no specific unit.

https://edit.arduino.cc/en/Reference/ArduinoMKRENV

@tigoe
Copy link

tigoe commented Apr 25, 2019 via email

@sandeepmistry
Copy link
Contributor Author

Good point Simone. ReadLight? ReadLightSensor? ReadLightLevel?

I'm ok with readLightLevel() or readIlluminace(). Let's see what @cmaglie thinks, as I discussed using readBrightness() with him yesterday.

@SimonePDA
Copy link

SimonePDA commented Apr 25, 2019

I chose to put all the values and their ranges in the main lib page. I think it gives a better picture of the shield performance/capabilities. The same table should go in the GS Page, now that we have agreed on what it is in it...

@tigoe
Copy link

tigoe commented Apr 25, 2019 via email

@cmaglie
Copy link

cmaglie commented Apr 26, 2019

getIlluminace is as good as getBrightness, either one are fine IMHO

@sandeepmistry
Copy link
Contributor Author

Ok, let's go with readIlluminace() then. I'll merge this now.

@sandeepmistry sandeepmistry changed the title Add readBrightness() API to replace readLux() Add readIlluminace() API to replace readLux() Apr 26, 2019
@sandeepmistry sandeepmistry merged commit 0d91a6d into master Apr 26, 2019
@sandeepmistry sandeepmistry changed the title Add readIlluminace() API to replace readLux() Add readIlluminance() API to replace readLux() Apr 26, 2019
@cmaglie cmaglie deleted the read-brightness branch April 29, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants