-
Notifications
You must be signed in to change notification settings - Fork 9
Add readIlluminance() API to replace readLux() #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am not sure if "brightness" is the right name of this measured value. It is the reading of the luminous flux that hits the sensor. If this flux is unfocused and from the environment it is the "ambient light" reading. |
|
@SimonePDA thanks for the feedback, do you have a preferred API name then? |
|
Let's hear what the others have to say. |
|
Good point Simone. ReadLight? ReadLightSensor? ReadLightLevel?
While we're at it, what are the SI units of UVA, B, and uvindex?
T
…On Wed, Apr 24, 2019, 10:05 AM Simone Majocchi ***@***.***> wrote:
Let's hear what the others have to say.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC45HZWCNHQ5CTXFWXQZUDPSBSLTANCNFSM4HIEDERQ>
.
|
|
As I added on the main lib page, the UVa and UVb vaue is the count of μW/cm2; this is stated on the datasheet. The UVIndex is an index, from 0 to 11+ with no specific unit. |
|
Good, thank you! I missed that detail.
t.
…On Thu, Apr 25, 2019 at 4:25 AM Simone Majocchi ***@***.***> wrote:
As I added on the main lib page, the UVa and UVb vaue is the count of
μW/cm2; this is stated on the datasheet.
The UVIndex is an index, from 0 to 11+ with no specific unit.
https://edit.arduino.cc/en/Reference/ArduinoMKRENV
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC45H547MX2ED332ZWDTUTPSFTIFANCNFSM4HIEDERQ>
.
|
I'm ok with |
|
I chose to put all the values and their ranges in the main lib page. I think it gives a better picture of the shield performance/capabilities. The same table should go in the GS Page, now that we have agreed on what it is in it... |
|
Sounds good. That page seems to still be behind the edit password, which I
don't have. Let me know when you're done and ready for feedback.
t.
…On Thu, Apr 25, 2019 at 9:33 AM Simone Majocchi ***@***.***> wrote:
I chose to put all the values and their ranges in the main lib page. I
think it gives a better picture of the shield performance/capabilities.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC45HZRX2T3RZILZMUOWFTPSGXI3ANCNFSM4HIEDERQ>
.
|
|
getIlluminace is as good as getBrightness, either one are fine IMHO |
|
Ok, let's go with |
53126d8 to
05971ff
Compare
From the discussion in #1 (comment).
cc/ @tigoe @SimonePDA @per1234 @cmaglie