Skip to content

Conversation

@sandeepmistry
Copy link

Without this patch RestClient(Client& netClient, const char* _host) was the only constructor to initialize this->timeout, so if RestClient(Client& netClient, const char* _host, int _port) was used it would have a timeout of 0 causing issues like #7.

This patch:

  • reduces duplication in the constructors, ensures timeout is always set (resolves Status = 0 unless delay is increased #7)
  • bumps the default timeout to 10s (previous was 1s)
  • removes an unnecessary delay in the library

cc/ @tigoe @don

@LucaCerina
Copy link

+1 on this pull-request, I encountered the same exact problem.
Why it didn't got accepted in 2 years?

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Status = 0 unless delay is increased

3 participants