-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Labels
status: waiting for informationMore information must be provided before work can proceedMore information must be provided before work can proceedtopic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project
Description
I think the SIGFOXClass::end() routine have some issues. See the commented lines for details:
void SIGFOXClass::end()
{
//Commented. I think its not right to assing LOW as a PIN-MODE
//pinMode(poweron_pin, LOW);
//delay(1);
digitalWrite(chip_select_pin, LOW);
delay(1);
spi_port->beginTransaction(SPICONFIG);
spi_port->transfer(0x05);
spi_port->endTransaction();
delay(1);
digitalWrite(chip_select_pin, HIGH);
//Added to switch off power supply to Sigfox module
delay(1);
digitalWrite(poweron_pin, LOW);
}Metadata
Metadata
Assignees
Labels
status: waiting for informationMore information must be provided before work can proceedMore information must be provided before work can proceedtopic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project