Skip to content

Update YOUR_FIRST_PR.md #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Update YOUR_FIRST_PR.md #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions YOUR_FIRST_PR.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

## Prerequisites

Before you start working on Science Journal Android, make sure you've read [CONTRIBUTING.md](https://github.com/bcmi-labs/Science-Journal-Android/blob/master/CONTRIBUTING.md).
Before you start working on Science Journal Android, make sure you've read [CONTRIBUTING.md](https://github.com/arduino/Arduino-Science-Journal-Android/blob/main/CONTRIBUTING.md).

## Finding things to work on

If you want to work on something else, e.g. new functionality or fixing a bug, it would be helpful if you submit a new issue so we have a chance to discuss it first. We might have some pointers for you on how to get started, or how to best integrate it with existing solutions.

## Checking out the Science Journal Android repo

- Click the “Fork” button in the upper right corner of the [main Science Journal Android repo](https://github.com/bcmi-labs/Science-Journal-Android)
- Click the “Fork” button in the upper right corner of the [main Science Journal Android repo](https://github.com/arduino/Arduino-Science-Journal-Android)
- Clone your fork:
- `git clone git@github.com:<YOUR_GITHUB_USER>/Science-Journal-Android.git`
- Learn more about how to manage your fork: [https://help.github.com/articles/working-with-forks/](https://help.github.com/articles/working-with-forks/)
Expand All @@ -26,7 +26,7 @@ Test on device! We ask you test your change on Android.

## Submitting a PR

When the coding is done and you’ve finished testing your changes, you're ready to submit a PR to the [Arduino Science Journal Android main repo](https://github.com/bcmi-labs/Science-Journal-Android). Everything you need to know about submitting the PR itself is inside our [Pull Request Template](https://github.com/bcmi-labs/Science-Journal-Android/blob/master/PULL_REQUEST_TEMPLATE.md). Some best practices are:
When the coding is done and you’ve finished testing your changes, you're ready to submit a PR to the [Arduino Science Journal Android main repo](https://github.com/arduino/Arduino-Science-Journal-Android). Everything you need to know about submitting the PR itself is inside our [Pull Request Template](https://github.com/arduino/Arduino-Science-Journal-Android/blob/main/PULL_REQUEST_TEMPLATE.md). Some best practices are:

- Use a descriptive title
- Link the issues related to your PR in the body
Expand Down