Solve mouseover + dropdown deadly combo

Author: facchinm

app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCellEditor.java

@@ -76,9 +76,12 @@ public Component getTableCellEditorComponent(JTable table, Object value,
       ContributedLibrary lib = (ContributedLibrary) chooser.getSelectedItem();
       onInstall(lib, editorValue.getInstalled());
     });
-    editorCell.versionToInstallChooser.addItemListener(e -> editorValue
-        .select((ContributedLibrary) editorCell.versionToInstallChooser
-            .getSelectedItem()));
+    editorCell.versionToInstallChooser.addActionListener(e -> {
+      editorValue.select((ContributedLibrary) editorCell.versionToInstallChooser.getSelectedItem());
+      if (editorCell.versionToInstallChooser.getSelectedIndex() != 0) {
+        InstallerTableCell.dropdownSelected(true);
+      }
+    });
 
     setEnabled(true);
 

app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCellJPanel.java

@@ -54,10 +54,13 @@ public ContributedLibraryTableCellJPanel(JTable parentTable, Object value,
     downgradeChooser.addItem("-");
     downgradeChooser.setMaximumSize(new Dimension((int)downgradeChooser.getPreferredSize().getWidth() + 50, (int)downgradeChooser.getPreferredSize().getHeight()));
     downgradeChooser.setMinimumSize(new Dimension((int)downgradeChooser.getPreferredSize().getWidth() + 50, (int)downgradeChooser.getPreferredSize().getHeight()));
-    downgradeChooser.addItemListener(e -> {
+    downgradeChooser.addActionListener(e -> {
       Object selectVersionItem = downgradeChooser.getItemAt(0);
-      boolean disableDowngrade = (e.getItem() == selectVersionItem);
+      boolean disableDowngrade = (downgradeChooser.getSelectedItem() == selectVersionItem);
       downgradeButton.setEnabled(!disableDowngrade);
+      if (!disableDowngrade) {
+        InstallerTableCell.dropdownSelected(true);
+      }
     });
 
     versionToInstallChooser = new JComboBox();

app/src/cc/arduino/contributions/ui/InstallerJDialog.java

@@ -171,10 +171,22 @@ public void keyReleased(KeyEvent keyEvent) {
 
     contribTable.addMouseMotionListener(new MouseMotionListener() {
 
+        int previousRowAtPoint = -1;
+
         public void mouseDragged(MouseEvent e) {}
 
         public void mouseMoved(MouseEvent e) {
-            contribTable.editCellAt(contribTable.rowAtPoint(e.getPoint()), 0);
+            // avoid firing edits events until:
+            int rowAtPoint = contribTable.rowAtPoint(e.getPoint());
+            if (!InstallerTableCell.isDropdownSelected() && rowAtPoint != previousRowAtPoint) {
+              contribTable.editCellAt(rowAtPoint, 0);
+              previousRowAtPoint = rowAtPoint;
+              InstallerTableCell.dropdownSelected(false);
+            }
+            if (InstallerTableCell.isDropdownSelected() && rowAtPoint == previousRowAtPoint) {
+              // back to the original cell, can drop dropdown selector lock
+              InstallerTableCell.dropdownSelected(false);
+            }
         }
     });
 

app/src/cc/arduino/contributions/ui/InstallerTableCell.java

@@ -41,6 +41,16 @@ public abstract class InstallerTableCell extends AbstractCellEditor implements T
 
   abstract public void setEnabled(boolean b);
 
+  private static boolean dropdownSelected = false;
+
+  public static boolean isDropdownSelected( ) {
+    return dropdownSelected;
+  }
+
+  public static void dropdownSelected(boolean b) {
+    dropdownSelected = b;
+  }
+
   abstract public void setStatus(String s);
 
   public static void setJTextPaneDimensionToFitContainedText(JTextPane jTextPane, int width) {