Fix category selection missing first input

Author: facchinm

app/src/cc/arduino/contributions/libraries/ui/LibraryManagerUI.java

@@ -119,6 +119,7 @@ public LibraryManagerUI(Frame parent, LibraryInstaller installer) {
     @Override
     public void actionPerformed(ActionEvent event) {
       DropdownItem<ContributedLibrary> selected = (DropdownItem<ContributedLibrary>) typeChooser.getSelectedItem();
+      previousRowAtPoint = -1;
       if (typeFilter == null || !typeFilter.equals(selected)) {
         typeFilter = selected.getFilterPredicate();
         if (contribTable.getCellEditor() != null) {

app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCellEditor.java

@@ -74,9 +74,12 @@ public Component getTableCellEditorComponent(JTable table, Object _value,
           .getSelectedItem();
       onInstall(selected, value.getInstalled());
     });
-    cell.versionToInstallChooser.addItemListener(e -> value
-        .select((ContributedPlatform) cell.versionToInstallChooser
-            .getSelectedItem()));
+    cell.versionToInstallChooser.addActionListener(e -> {
+      value.select((ContributedPlatform) cell.versionToInstallChooser.getSelectedItem());
+      if (cell.versionToInstallChooser.getSelectedIndex() != 0) {
+        InstallerTableCell.dropdownSelected(true);
+      }
+    });
 
     setEnabled(true);
 

app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCellJPanel.java

@@ -98,6 +98,9 @@ public ContributedPlatformTableCellJPanel() {
       Object selectVersionItem = downgradeChooser.getItemAt(0);
       boolean disableDowngrade = (e.getItem() == selectVersionItem);
       downgradeButton.setEnabled(!disableDowngrade);
+      if (!disableDowngrade) {
+        InstallerTableCell.dropdownSelected(true);
+      }
     });
 
     versionToInstallChooser = new JComboBox();

app/src/cc/arduino/contributions/ui/InstallerJDialog.java

@@ -90,6 +90,8 @@ public abstract class InstallerJDialog<T> extends JDialog {
   private final JButton closeButton;
   private final JButton dismissErrorMessageButton;
 
+  protected int previousRowAtPoint = -1;
+
   abstract protected FilteredAbstractTableModel<T> createContribModel();
 
   abstract protected TableCellRenderer createCellRenderer();
@@ -120,6 +122,7 @@ public InstallerJDialog(Frame parent, String title, ModalityType applicationModa
       filterField = new FilterJTextField(tr("Filter your search...")) {
         @Override
         protected void onFilter(String[] _filters) {
+          previousRowAtPoint = -1;
           filters = _filters;
           if (contribTable.getCellEditor() != null) {
             contribTable.getCellEditor().stopCellEditing();
@@ -171,12 +174,10 @@ public void keyReleased(KeyEvent keyEvent) {
 
     contribTable.addMouseMotionListener(new MouseMotionListener() {
 
-        int previousRowAtPoint = -1;
-
         public void mouseDragged(MouseEvent e) {}
 
         public void mouseMoved(MouseEvent e) {
-            // avoid firing edits events until:
+            // avoid firing edits events until the mouse changes cell or the user is back on the cell after selecting a dropdown
             int rowAtPoint = contribTable.rowAtPoint(e.getPoint());
             if (!InstallerTableCell.isDropdownSelected() && rowAtPoint != previousRowAtPoint) {
               contribTable.editCellAt(rowAtPoint, 0);
@@ -309,6 +310,7 @@ private void setErrorMessageVisible(boolean visible) {
     @Override
     public void actionPerformed(ActionEvent event) {
       DropdownItem<T> selected = (DropdownItem<T>) categoryChooser.getSelectedItem();
+      previousRowAtPoint = -1;
       if (categoryFilter == null || !categoryFilter.equals(selected)) {
         categoryFilter = selected.getFilterPredicate();
         if (contribTable.getCellEditor() != null) {