Using just #include "Arduino.h" all times

[avandalen]

It would be nice if "Arduino.h" is changed in such a way that just this:

include "Arduino.h"

can be used every time instead of this ugly code:

if ARDUINO >= 100

#include "Arduino.h"

else

#include "WProgram.h"

endif

[matthijskooijman]

#include WProgram.h is required for Arduino versions < 1.0. Since we cannot re-release all past versions (and certainly not magically replace already released versions), there's nothing we can do in this regard with new versions.

However, since 1.0 has been released for quite some time now, you could consider to stop supporting Arduino versions older than 1.0 and only include Arduino.h.

[PaulStoffregen]

I've seen several new libraries that use Arduino 1.0 API features, so they can't possibly work on pre-1.0 versions. But still, they almost all have this code to include WProgram.h. It seems many author simply copy from earlier libraries. I believe this block of code will be around for a very long time.

[avandalen]

I experience that many people still encounter problems if the code is omitted.

#if ARDUINO >= 100
#include "Arduino.h"
#else
#include "WProgram.h"
#endif

If this code (modificated) would be included in Arduino.h then it is not necessary anymore to include this code in programs every time, and we can just use #include "Arduino.h". This makes life easier.

[matthijskooijman]

Please show actual examples of problems caused by not including WProgram.h. What you suggest makes no sense at all - the current Arduino versions do not contain a WProgram.c and #define ARDUINO at 106 or 158. Furthermore, including Arduino.h from within itself will certainly not help either.

I cannot be sure that there are corner cases with specific code sequences that do not work without the WProgram.h include (though I cannot really think of any way this could happen without really weird code, including things like #undef ARDUINO), but I am completely sure that adding that code to Arduino.h does not make sense. If not having that code around causes a problem in some code, that code should be fixed.

Really, I don't intend to be harsh and I welcome contributions and feedback, but your proposal simply doesn't make sense. If you can find a specific case where removing that code causes a problem, I'm happy to help investigate how to fix that.

[avandalen]

Other people who use my libraries sometimes have problems when using older Arduino versions and they need to add the code fragment:

#if ARDUINO >= 100

#include "Arduino.h"

#else

#include "WProgram.h"

#endif

So, I agree, it is better to tell them that they should use the recent Arduino version, and just include "Arduino.h"

This will solve it.

Thanks and best regards,

Albert

----- Original Message -----
From: Matthijs Kooijman
To: arduino/Arduino
Cc: Albert van Dalen
Sent: Thursday, October 02, 2014 3:36 PM
Subject: Re: [Arduino] Using just #include "Arduino.h" all times (#2341)

Please show actual examples of problems caused by not including WProgram.h. What you suggest makes no sense at all - the current Arduino versions do not contain a WProgram.c and #define ARDUINO at 106 or 158. Furthermore, including Arduino.h from within itself will certainly not help either.

I cannot be sure that there are corner cases with specific code sequences that do not work without the WProgram.h include (though I cannot really think of any way this could happen without really weird code, including things like #undef ARDUINO), but I am completely sure that adding that code to Arduino.h does not make sense. If not having that code around causes a problem in some code, that code should be fixed.

Really, I don't intend to be harsh and I welcome contributions and feedback, but your proposal simply doesn't make sense. If you can find a specific case where removing that code causes a problem, I'm happy to help investigate how to fix that.

—
Reply to this email directly or view it on GitHub.

---

This email is free from viruses and malware because avast! Antivirus protection is active.
http://www.avast.com

[matthijskooijman]

Yes, if they use Arduino versions older than 1.0, they'll have to use that code. But we cannot change their installed IDE versions, so there's nothing we can do to fix that. And indeed, telling them to upgrade to a newer version doesn't seem unreasonable to me.