Allows HttpClient to call https urls #2084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calling https URLs without checking for the validity of SSL certificates. While this makes it a little insecure, nothing else can be done while keeping the HTTPClient API simple: openwrt does not have a SSL certificates bundle Advanced users concerned about security should call "curl" on their own using Process, supplying parameters such as "--cacert" Fixes #1860
Collaborator
|
I'm wondering if this should be opt-in by calling a "noCheckSSL()" function or something like that? I'm afraid that passing this implicitely will give users a false sense of security. "Hey, I'm secure, since I'm using HTTPS and it worked right away!" |
If insecure, "-k" parameter is added to curl and SSL certificates are not checked
Contributor
Author
|
Agree. I've added noCheckSSL and checkSSL methods |
Collaborator
|
Looks good! |
cmaglie
added a commit
that referenced
this pull request
May 21, 2014
Allows HttpClient to call https urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parameter "-k" to every way of calling curl, hence allowing
calling https URLs without checking for the validity of SSL
certificates.
While this makes it a little insecure, nothing else can be done
while keeping the HTTPClient API simple: openwrt does not have a
SSL certificates bundle
Advanced users concerned about security should call "curl" on
their own using Process, supplying parameters such as "--cacert"
Fixes #1860
@cmaglie