Skip to content

Fix HW+CDC Serial buffer size determination #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2015
Merged

Fix HW+CDC Serial buffer size determination #3826

merged 2 commits into from
Sep 21, 2015

Conversation

@NicoHood
Copy link
Contributor

Fixes issue #3822

@matthijskooijman
Copy link
Collaborator

Commits look ok to me, though a bit more rationale in the commit message wouldn't hurt (as I already asked in the issue too).

@cmaglie cmaglie added Component: Core Related to the code for the standard Arduino API Component: HardwareSerial The hardware serial functionality of the core libraries Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) Component: USB Device Opposed to USB Host. Related to the USB subsystem (SerialUSB, HID, ...) feature request A request to make an enhancement (not a bug fix) USB: CDC serial Serial interface used by MCUs with native USB (e.g. Leonardo) to communicate with the computer and removed Component: USB Device Opposed to USB Host. Related to the USB subsystem (SerialUSB, HID, ...) labels Sep 21, 2015
@cmaglie cmaglie merged commit 8a96e75 into arduino:master Sep 21, 2015
@facchinm facchinm mentioned this pull request Sep 21, 2015
Closed
@ffissore ffissore added this to the Release 1.6.6 milestone Sep 23, 2015
@NicoHood NicoHood deleted the patch-7 branch September 28, 2015 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cmaglie cmaglie

Labels

Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) Component: Core Related to the code for the standard Arduino API Component: HardwareSerial The hardware serial functionality of the core libraries feature request A request to make an enhancement (not a bug fix) USB: CDC serial Serial interface used by MCUs with native USB (e.g. Leonardo) to communicate with the computer

Projects

None yet

Milestone

Release 1.6.6

Development

Successfully merging this pull request may close these issues.

4 participants

@NicoHood @matthijskooijman @cmaglie @ffissore