refactoring test constants

Author: mirkoCrobu

internal/e2e/daemon/app_test.go

@@ -470,7 +470,7 @@ func TestDeleteApp(t *testing.T) {
 
 	t.Run("DeletingExampleApp_Fail", func(t *testing.T) {
 		var actualResponseBody models.ErrorResponse
-		deleteResp, err := httpClient.DeleteApp(t.Context(), noExisitingExample)
+		deleteResp, err := httpClient.DeleteApp(t.Context(), "ZXhhbXBsZXM6anVzdGJsaW5f")
 		require.NoError(t, err)
 		defer deleteResp.Body.Close()
 
@@ -818,7 +818,7 @@ func TestAppPorts(t *testing.T) {
 		respBrick, err := httpClient.UpsertAppBrickInstanceWithResponse(
 			t.Context(),
 			*createResp.JSON201.Id,
-			StreamLitUi,
+			"arduino:streamlit_ui",
 			client.BrickCreateUpdateRequest{},
 			func(ctx context.Context, req *http.Request) error { return nil },
 		)

internal/e2e/daemon/const.go

@@ -15,35 +15,8 @@
 
 package daemon
 
-import (
-	"go.bug.st/f"
-
-	"github.com/arduino/arduino-app-cli/internal/e2e/client"
-)
-
 const (
-	ImageClassifactionBrickID      = "arduino:image_classification"
-	StreamLitUi                    = "arduino:streamlit_ui"
-	expectedDetailsAppNotfound     = "unable to find the app"
-	expectedDetailsAppInvalidAppId = "invalid app id"
-	noExistingApp                  = "dXNlcjp0ZXN0LWFwcAw"
-	malformedAppId                 = "this-is-definitely-not-base64"
-	noExisitingExample             = "ZXhhbXBsZXM6anVzdGJsaW5f"
-)
-
-var (
-	expectedVariablesDetails = []client.BrickInstanceVariable{
-		{
-			Description: f.Ptr("path to the custom model directory"),
-			Name:        f.Ptr("CUSTOM_MODEL_PATH"),
-			Required:    f.Ptr(false),
-			Value:       f.Ptr("/home/arduino/.arduino-bricks/ei-models"),
-		},
-		{
-			Description: f.Ptr("path to the model file"),
-			Name:        f.Ptr("EI_CLASSIFICATION_MODEL"),
-			Required:    f.Ptr(false),
-			Value:       f.Ptr("/models/ootb/ei/mobilenet-v2-224px.eim"),
-		},
-	}
+	ImageClassifactionBrickID = "arduino:image_classification"
+	noExistingApp             = "dXNlcjp0ZXN0LWFwcAw"
+	malformedAppId            = "this-is-definitely-not-base64"
 )

internal/e2e/daemon/instance_bricks_test.go

@@ -31,6 +31,28 @@ import (
 	"github.com/arduino/arduino-app-cli/internal/e2e/client"
 )
 
+const (
+	expectedDetailsAppInvalidAppId = "invalid app id"
+	expectedDetailsAppNotfound     = "unable to find the app"
+)
+
+var (
+	expectedVariablesDetails = []client.BrickInstanceVariable{
+		{
+			Description: f.Ptr("path to the custom model directory"),
+			Name:        f.Ptr("CUSTOM_MODEL_PATH"),
+			Required:    f.Ptr(false),
+			Value:       f.Ptr("/home/arduino/.arduino-bricks/ei-models"),
+		},
+		{
+			Description: f.Ptr("path to the model file"),
+			Name:        f.Ptr("EI_CLASSIFICATION_MODEL"),
+			Required:    f.Ptr(false),
+			Value:       f.Ptr("/models/ootb/ei/mobilenet-v2-224px.eim"),
+		},
+	}
+)
+
 func setupTestApp(t *testing.T) (*client.CreateAppResp, *client.ClientWithResponses) {
 	httpClient := GetHttpclient(t)
 	createResp, err := httpClient.CreateAppWithResponse(