Skip to content

Deprecate require_devices in YAML brick index #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giulio93 merged 1 commit into from
Nov 27, 2025
Merged

Deprecate require_devices in YAML brick index #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/orchestrator/bricks/testdata/bricks-list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ bricks:
description: Connects to Arduino Cloud
require_container: false
require_model: false
require_devices: false
mount_devices_into_container: false
ports: []
category: null
Expand All @@ -19,7 +18,6 @@ bricks:
local database.
require_container: false
require_model: false
require_devices: false
mount_devices_into_container: false
ports: []
category: storage
Expand Down
1 change: 0 additions & 1 deletion internal/orchestrator/bricksindex/bricks_index_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ func TestBricksIndexYAMLFormats(t *testing.T) {
category: storage
require_container: true
require_model: true
require_devices: false
mount_devices_into_container: true
model_name: a-complex-model
required_devices:
Expand Down
2 changes: 0 additions & 2 deletions internal/orchestrator/orchestrator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,6 @@ bricks:
\ or with custom object detection models trained on Edge Impulse platform. \n"
require_container: true
require_model: true
require_devices: false
ports: []
category: video
model_name: yolox-object-detection
Expand Down Expand Up @@ -533,7 +532,6 @@ bricks:
\ or with custom object detection models trained on Edge Impulse platform. \n"
require_container: true
require_model: true
require_devices: false
category: video
model_name: yolox-object-detection
variables:
Expand Down
2 changes: 1 addition & 1 deletion internal/orchestrator/provision.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ func generateMainComposeFile(
}

// 4. Retrieve the required devices that we have to mount
slog.Debug("Brick config", slog.Bool("require_devices", idxBrick.MountDevicesIntoContainer), slog.Any("ports", ports), slog.Any("required_devices", idxBrick.RequiredDevices))
slog.Debug("Brick config", slog.Bool("mount_devices_into_container", idxBrick.MountDevicesIntoContainer), slog.Any("ports", ports), slog.Any("required_devices", idxBrick.RequiredDevices))
if idxBrick.MountDevicesIntoContainer {
servicesThatRequireDevices = slices.AppendSeq(servicesThatRequireDevices, maps.Keys(svcs))
}
Expand Down