Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/api/docs/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,15 @@ components:
$ref: '#/components/schemas/ErrorResponse'
description: Precondition Failed
schemas:
AIModel:
properties:
description:
type: string
id:
type: string
name:
type: string
type: object
AIModelItem:
properties:
brick_ids:
Expand Down Expand Up @@ -1336,6 +1345,10 @@ components:
type: string
category:
type: string
compatible_models:
items:
$ref: '#/components/schemas/AIModel'
type: array
config_variables:
items:
$ref: '#/components/schemas/BrickConfigVariable'
Expand Down
24 changes: 16 additions & 8 deletions internal/e2e/client/client.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,18 @@ var (
Value: f.Ptr("/models/ootb/ei/mobilenet-v2-224px.eim"),
},
}

expectedModelInfo = []client.AIModel{
{
Id: f.Ptr("mobilenet-image-classification"),
Name: f.Ptr("General purpose image classification"),
Description: f.Ptr("General purpose image classification model based on MobileNetV2. This model is trained on the ImageNet dataset and can classify images into 1000 categories."),
},
{
Id: f.Ptr("person-classification"),
Name: f.Ptr("Person classification"),
Description: f.Ptr("Person classification model based on WakeVision dataset. This model is trained to classify images into two categories: person and not-person."),
}}
)

func setupTestApp(t *testing.T) (*client.CreateAppResp, *client.ClientWithResponses) {
Expand Down Expand Up @@ -78,7 +90,6 @@ func setupTestApp(t *testing.T) (*client.CreateAppResp, *client.ClientWithRespon
)
require.NoError(t, err)
require.Equal(t, http.StatusOK, resp.StatusCode())

return createResp, httpClient
}

Expand Down Expand Up @@ -135,6 +146,20 @@ func TestGetAppBrickInstanceById(t *testing.T) {
require.NotEmpty(t, brickInstance.JSON200)
require.Equal(t, ImageClassifactionBrickID, *brickInstance.JSON200.Id)
require.Equal(t, expectedConfigVariables, (*brickInstance.JSON200.ConfigVariables))
require.Nil(t, brickInstance.JSON200.CompatibleModels)
})

t.Run("GetAppBrickInstanceByBrickIDWithCompatibleModels_Success", func(t *testing.T) {
brickInstance, err := httpClient.GetAppBrickInstanceByBrickIDWithResponse(
t.Context(),
*createResp.JSON201.Id,
ImageClassifactionBrickID,
func(ctx context.Context, req *http.Request) error { return nil })
require.NoError(t, err)
require.NotEmpty(t, brickInstance.JSON200)
require.Equal(t, ImageClassifactionBrickID, *brickInstance.JSON200.Id)
require.NotNil(t, brickInstance.JSON200.CompatibleModels)
require.Equal(t, expectedModelInfo, *(brickInstance.JSON200.CompatibleModels))
})

t.Run("GetAppBrickInstanceByBrickID_InvalidAppID_Fails", func(t *testing.T) {
Expand Down
7 changes: 7 additions & 0 deletions internal/orchestrator/bricks/bricks.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,13 @@ func (s *Service) AppBrickInstanceDetails(a *app.ArduinoApp, brickID string) (Br
Variables: variables,
ConfigVariables: configVariables,
ModelID: modelID,
CompatibleModels: f.Map(s.modelsIndex.GetModelsByBrick(brick.ID), func(m modelsindex.AIModel) AIModel {
return AIModel{
ID: m.ID,
Name: m.Name,
Description: m.ModuleDescription,
}
}),
}, nil
}

Expand Down
22 changes: 14 additions & 8 deletions internal/orchestrator/bricks/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,22 @@ type AppBrickInstancesResult struct {
}

type BrickInstance struct {
ID string `json:"id"`
Name string `json:"name"`
Author string `json:"author"`
Category string `json:"category"`
Status string `json:"status"`
Variables map[string]string `json:"variables,omitempty" description:"Deprecated: use config_variables instead. This field is kept for backward compatibility."`
ConfigVariables []BrickConfigVariable `json:"config_variables,omitempty"`
ModelID string `json:"model,omitempty"`
ID string `json:"id"`
Name string `json:"name"`
Author string `json:"author"`
Category string `json:"category"`
Status string `json:"status"`
Variables map[string]string `json:"variables,omitempty" description:"Deprecated: use config_variables instead. This field is kept for backward compatibility."`
ConfigVariables []BrickConfigVariable `json:"config_variables,omitempty"`
ModelID string `json:"model,omitempty"`
CompatibleModels []AIModel `json:"compatible_models,omitempty"`
}

type AIModel struct {
ID string `json:"id"`
Name string `json:"name"`
Description string `json:"description"`
}
type BrickConfigVariable struct {
Name string `json:"name"`
Value string `json:"value"`
Expand Down
Loading