slightly refactor serial port listing

Author: facchinm

serial.go

@@ -144,7 +144,15 @@ func discoverLoop() {
 func spListDual(network bool) {
 
 	// call our os specific implementation of getting the serial list
-	list, _ := GetList(network)
+	list, err := GetList(network)
+
+	log.Println(list)
+	log.Println(err)
+
+	if err != nil {
+		// avoid reporting dummy data if an error occurred
+		return
+	}
 
 	// do a quick loop to see if any of our open ports
 	// did not end up in the list port list. this can

seriallist.go

@@ -27,47 +27,46 @@ func GetList(network bool) ([]OsSerialPort, error) {
 	if network {
 		netportList, err := GetNetworkList()
 		return netportList, err
-	} else {
+	}
 
-		// will timeout in 2 seconds
-		arrPorts := []OsSerialPort{}
-		ports, err := enumerator.GetDetailedPortsList()
-		if err != nil {
-			return arrPorts, err
-		}
+	// will timeout in 2 seconds
+	arrPorts := []OsSerialPort{}
+	ports, err := enumerator.GetDetailedPortsList()
+	if err != nil {
+		return arrPorts, err
+	}
 
-		for _, element := range ports {
-			if element.IsUSB {
-				vid := element.VID
-				pid := element.PID
-				vidString := fmt.Sprintf("0x%s", vid)
-				pidString := fmt.Sprintf("0x%s", pid)
-				if vid != "0000" && pid != "0000" {
-					arrPorts = append(arrPorts, OsSerialPort{Name: element.Name, IdVendor: vidString, IdProduct: pidString, ISerial: element.SerialNumber})
-				}
+	for _, element := range ports {
+		if element.IsUSB {
+			vid := element.VID
+			pid := element.PID
+			vidString := fmt.Sprintf("0x%s", vid)
+			pidString := fmt.Sprintf("0x%s", pid)
+			if vid != "0000" && pid != "0000" {
+				arrPorts = append(arrPorts, OsSerialPort{Name: element.Name, IdVendor: vidString, IdProduct: pidString, ISerial: element.SerialNumber})
 			}
 		}
+	}
 
-		// see if we should filter the list
-		if len(*regExpFilter) > 0 {
-			// yes, user asked for a filter
-			reFilter := regexp.MustCompile("(?i)" + *regExpFilter)
-
-			newarrPorts := []OsSerialPort{}
-			for _, element := range arrPorts {
-				// if matches regex, include
-				if reFilter.MatchString(element.Name) {
-					newarrPorts = append(newarrPorts, element)
-				} else {
-					log.Debug("serial port did not match. port: %v\n", element)
-				}
+	// see if we should filter the list
+	if len(*regExpFilter) > 0 {
+		// yes, user asked for a filter
+		reFilter := regexp.MustCompile("(?i)" + *regExpFilter)
 
+		newarrPorts := []OsSerialPort{}
+		for _, element := range arrPorts {
+			// if matches regex, include
+			if reFilter.MatchString(element.Name) {
+				newarrPorts = append(newarrPorts, element)
+			} else {
+				log.Debug("serial port did not match. port: %v\n", element)
 			}
-			arrPorts = newarrPorts
-		}
 
-		return arrPorts, err
+		}
+		arrPorts = newarrPorts
 	}
+
+	return arrPorts, err
 }
 
 func findPortByName(portname string) (*serport, bool) {

serialport.go

@@ -321,6 +321,10 @@ func spHandlerOpen(portname string, baud int, buftype string) {
 	// this is thread to send to serial port regardless of block
 	go p.writerNoBuf()
 	p.reader()
+
+	spListDual(false)
+	spList(false)
+
 	//go p.reader()
 	//p.done = make(chan bool)
 	//<-p.done