feat: remove bufferAlgorithm param from the open command

[dido18]

Please check if the PR fulfills these requirements

• The PR has no duplicates (please search among the Pull Requests
  before creating one)
• Tests for the changes have been added (for bug fixes / features)

• What kind of change does this PR introduce?
  Remove the bufferAlgorithm argument from the open command.
  Reasons: the Arduino projects use only the timed algorithm. No need for the other two options.
  • Editor uses only the timed option.
  • Arduino-create-agent-js-client uses only the timed option.

• What is the current behavior?
  The open command accepts 3 different bufferAlgorithm.
  open <portName> <baud> [bufferAlgorithm: ({default}, timed, timedraw)]

• What is the new behavior?
  The bufferAlgorithm argument is removed and it not possible to set the algorithm (the timed is always used)
  open <portName> <baud>.
  If the argument is specified, the following warn log is printed:

level=warning msg="Unexpected arguments for the open command. Ignored arguments: '[timed]'."

• Does this PR introduce a breaking change?

• Other information:

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 20.84%. Comparing base (1b94ccc) to head (fb39e25).

Files with missing lines	Patch %	Lines
serialport.go	0.00%	8 Missing ⚠️
bufferflow_timed.go	0.00%	2 Missing ⚠️
hub.go	0.00%	2 Missing ⚠️
serial.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   20.14%   20.84%   +0.69%     
==========================================
  Files          42       40       -2     
  Lines        3222     3114     -108     
==========================================
  Hits          649      649              
+ Misses       2488     2380     -108     
  Partials       85       85              

Flag	Coverage Δ
unit	20.84% <0.00%> (+0.69%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dido18]

TODO

• Test on Linux: I provisioned successfully an Arduino UNO r4 board (on ubuntu 20.04)
• Test on Windows
• Test on mac
• Update the WIKI page

[cmaglie]

Looks good!
Just added a comment for future reference.

[cmaglie]

Retested on Linux, and now seems working OK! ✅

[dido18]

Despite that the timedraw is not being used by any App provided by Arduino, we may not remove this parameter. It could be used to send raw bytes to the boards.

The timedraw buffer algorithm in the open command can be used to open a serial port and receive raw bytes from it (converted into base64 via the json.marshal).

Using the echo sketch in the testdata I tested the following scenario:

• open the serial port using the timedraw algorithm
• send a raw bytes (encoded in base64) to the serial
• the board echoes the received data
• the WebSocket receives the "D": "AQIDBAU=" raw bytes encoded in base64

open /dev/ttyACM0 9600 timedraw

{
  "Cmd": "Open",
  "Desc": "Got register/open on port.",
  "Port": "/dev/ttyACM0",
  "Baud": 9600,
  "BufferType": "timedraw"
}

sendraw /dev/ttyACM0 AQIDBAU=

{
  "P": "/dev/ttyACM0",
  "D": "AQIDBAU="
}

To generate the raw bytes use the following code:

package main

import (
	"encoding/base64"
	"fmt"
)

func main() {
	data := []byte{0x01, 0x02, 0x03, 0x04, 0x05}
	encoded := base64.StdEncoding.EncodeToString(data)
	fmt.Println("Encoded:", encoded)
}

```

[dido18]

wiki reverted https://github.com/arduino/arduino-create-agent/wiki/How-to-use-the-agent#open-a-websocket

[dido18]

Closing because the open /dev/ttyACM0 XXXX timedraw command could be used by the Web IDE to upload binary data during the provisioning.