feat: expose Arduino state to VS Code extensions #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update a shared state on fqbn, port, sketch path, and etc. changes. VS Code extensions can access it and listen on changes. - Force VISX activation order: API VSIX starts first. Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
kittaakos
added
type: enhancement
4 tasks
Ref: eclipse-theia/theia#12587 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Removed the toolbar contribution from the UI. Ref: eclipse-theia/theia#12626/ Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
dankeboy36
force-pushed
the
set-arduino-context
branch
from
b36448b
to
18366e2
Compare
kittaakos
approved these changes
Jul 3, 2023
AlbyIanna
approved these changes
Jul 5, 2023
| @@ -0,0 +1,23 @@ | |||
| import { injectable } from '@theia/core/shared/inversify'; | |||
| import { TerminalWidgetImpl as TheiaTerminalWidgetImpl } from '@theia/terminal/lib/browser/terminal-widget-impl'; | |||
| import debounce from 'p-debounce'; | |||
There was a problem hiding this comment.
I noticed that in most files in the project we're using lodash.debounce, while only in one other file than this one we are using p-debounce. Maybe it makes sense to stick to one of them and remove a dependency from the project.
There was a problem hiding this comment.
Thanks for noticing it; I did not. It's because the change is the "cherry-pick" of the upstream fix, which uses p-debounce. See here: eclipse-theia/theia@6ab16d5#diff-da3ea75041150eb2403247c5ed84542210774c326c0e3b334029f4e3afb51fc0R45.
There was a problem hiding this comment.
Related: eclipse-theia/theia#9139
This was referenced Jul 10, 2023
This was referenced Aug 3, 2023
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow-up PR of #2071.
Motivation
To provide a way to implement external tools for the Arduino IDE without modifying the IDE codebase. See #58.
This PR introduces a tiny layer of code to listen to Arduino context-related changes and set it on the VS Code extension. Other VS Code extensions can import this new VSIX API and retrieve context information from the Arduino IDE—information such as the sketch path, FQBN of the currently selected board, etc. See
vscode-arduino-apifor more details.I have an ongoing reference re-implementation of the well-known ESP exception decoder. It works in the Arduino IDE.
Change description
Other information
Reviewer checklist