Add CI workflow to run tests #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Oct 30, 2020
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow is missing the step to upload coverage data to Codecov.io because that will fail unless an upload token is provided (https://docs.codecov.io/docs/about-the-codecov-bash-uploader#section-upload-token). That would require a secret to be created and I don't have the admin access to do it. Considering the coverage is 0, it's not an urgent matter.
The workflow is missing artifact creation. I need to figure out how to handle that, which may change depending on where we decide to host the schema. For now, I think it's worth just getting a minimal workflow in place and adding to it in subsequent PRs.