Skip to content

Conversation

dvarrel
Copy link
Contributor

@dvarrel dvarrel commented Dec 16, 2022

No description provided.

@github-actions
Copy link
Contributor

Hi @dvarrel.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Dec 16, 2022
@github-actions github-actions bot requested a review from per1234 December 16, 2022 12:31
@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Dec 16, 2022
@per1234
Copy link
Contributor

per1234 commented Dec 16, 2022

Hello @dvarrel. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

Note that it appears that, in addition to changing the library URL, which is now in progress, you are also attempting to change the library's name:

dvarrel/ESPping@f33c784#diff-f267f9ae2f5d5d56a1dbb305e95d40d4408d9ee7f71357f1f67fb18c29b7f082R1

- name=ESP_Ping
+ name=ESPping

If you want to do that, you must first make a release/tag that contains the change. The current release version of the library still uses the currently registered name "ESP_Ping":

https://github.com/dvarrel/ESPping/blob/1.0.0/library.properties#L1

name=ESP_Ping

You can learn how to request a name change here:

https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name

@github-actions
Copy link
Contributor

Hi @dvarrel.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot removed the status: pending backend Depends on backend maintenance operations label Dec 19, 2022
@github-actions github-actions bot removed the request for review from per1234 December 19, 2022 09:15
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/dvarrel/ESPping:

Linting library in ESPping
ERROR: Library name ESPping not found in the Library Manager index. Library names are not allowed to change after being 
       added to the index.                                                                                              
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in ESPping/examples/test_ping

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @dvarrel
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 December 19, 2022 09:16
@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Dec 20, 2022
@umbynos umbynos self-assigned this Dec 22, 2022
@umbynos
Copy link
Contributor

umbynos commented Dec 22, 2022

Done in #2256 (comment)

@umbynos umbynos merged commit b14acb8 into arduino:main Dec 22, 2022
@umbynos umbynos added the conclusion: resolved Issue was resolved label Dec 22, 2022
@per1234 per1234 added topic: URL change Change library repository URL and removed status: pending backend Depends on backend maintenance operations labels Apr 29, 2023
@per1234 per1234 removed the topic: modification Change existing list entry label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: resolved Issue was resolved topic: URL change Change library repository URL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants