Skip to content

Conversation

@leresteux
Copy link
Contributor

update name and header for Dunogeon project

@leresteux
Copy link
Contributor Author

sorry for the so many update

@github-actions github-actions bot added the topic: modification Change existing list entry label Dec 18, 2022
@github-actions
Copy link
Contributor

Hi @leresteux.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/leresteux/DunogeonFR:

Linting library in DunogeonFR
INFO: No header file found matching library name (DunogeonFR.h). Best practices are for primary header filename to match
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name DunogeonFR not found in the Library Manager index. Library names are not allowed to change after    
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in DunogeonFR/examples/DunogeonFR_v0-1

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @leresteux
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 December 18, 2022 11:59
@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Dec 18, 2022
@per1234
Copy link
Contributor

per1234 commented Dec 18, 2022

Hello @leresteux. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@umbynos umbynos self-assigned this Dec 22, 2022
@umbynos
Copy link
Contributor

umbynos commented Dec 22, 2022

Done in #2272 (comment)

@umbynos umbynos merged commit c67907f into arduino:main Dec 22, 2022
@umbynos umbynos added the conclusion: resolved Issue was resolved label Dec 22, 2022
@per1234 per1234 added topic: URL change Change library repository URL and removed status: pending backend Depends on backend maintenance operations labels Apr 29, 2023
@per1234 per1234 removed the topic: modification Change existing list entry label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: resolved Issue was resolved topic: URL change Change library repository URL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants