Skip to content

Conversation

@DefHam140
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

ERROR: Arduino Lint found errors with https://github.com/DefHam140/IOTClient:

Linting library in IOTClient
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           
INFO: No header file found matching library name (IOTClient.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Invalid category field value Communication  // Choose an appropriate category. in library.properties  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: library.properties includes field item(s) IOTClient.h not found in library.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: Sketch(es) found outside examples and extras folders:                                    
           IOTClient/IOTClient/Example/IOTClientBasic                                             
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 5 WARNINGS

-------------------

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @DefHam140
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@DefHam140 DefHam140 closed this by deleting the head repository Dec 1, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @DefHam140. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/DefHam140/IOTClient/tree/IOTClient

(note that there is no header file in the library's root source folder)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 self-assigned this Dec 1, 2023
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Dec 1, 2023
@per1234 per1234 mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: duplicate Has already been submitted topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants