Skip to content

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 7, 2021

The default value of the version input is defined in the action metadata, so having another default setting in the code
is purely redundant and doubles the maintenance effort required on every major release of Task (note that they already
went out of sync).

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 7, 2021
@per1234 per1234 requested review from rsora, silvanocerza and umbynos May 7, 2021 11:07
The default value of the version input is defined in the action metadata, so having another default setting in the code
is purely redundant and doubles the maintenance effort required on every major release of Task (note that they already
went out of sync).
@per1234 per1234 force-pushed the redundant-version-default branch from 2bd3384 to 5cf16d8 Compare May 7, 2021 21:17
@per1234 per1234 merged commit b9e8d90 into main May 7, 2021
@per1234 per1234 deleted the redundant-version-default branch May 7, 2021 21:22
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants